Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceAccount reconcile logic leads to authentication problems #428

Closed
eryalito opened this issue Oct 11, 2023 · 1 comment
Closed

ServiceAccount reconcile logic leads to authentication problems #428

eryalito opened this issue Oct 11, 2023 · 1 comment
Labels
enhancement Adding additional functionality or improvements stale Marked as stale by stalebot triage This bug needs triage

Comments

@eryalito
Copy link
Contributor

From #417 (comment)

TL:DR When a SA has to be updated the current logic is to delete the old one and create a new sa with the desired configuration

Each time the SA is marked as changed it needs to be reconciled: add/delete new secrets on the rbd, restore default conf after a manual editing of the object, etc. This leads to some problems when using serviceaccount identity. Currently I have located 2 cases where this is a problem:

  1. If a pod is using a SA to communicate with the APIServer (like operators) when the SA is recreated the mounted credentials on the pod is not refreshed, getting an Unauthorized message. This makes some operators and pods crash.
  2. When tokens are created and used to login into the cluster from the outside. For example automated tools that interacts with the cluster (ArgoCD, Jenkins, etc). If the SA is deleted and re-created the token is revoked, so the integration breaks.

IMHO this behaviour should be changed so the rbac-manager edit the existing SA when possible instead of recreating it.

@eryalito eryalito added the triage This bug needs triage label Oct 11, 2023
@sudermanjr
Copy link
Member

Related to, or a duplicate of: #386

@sudermanjr sudermanjr added the enhancement Adding additional functionality or improvements label Oct 11, 2023
@github-actions github-actions bot added the stale Marked as stale by stalebot label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements stale Marked as stale by stalebot triage This bug needs triage
Projects
None yet
Development

No branches or pull requests

2 participants