Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tagging #44

Closed
faisalsayed10 opened this issue Jun 4, 2023 · 5 comments
Closed

Implement tagging #44

faisalsayed10 opened this issue Jun 4, 2023 · 5 comments
Labels
codeday labs enhancement New feature or request

Comments

@faisalsayed10
Copy link
Owner

For CodeDay Labs

Object Storage buckets, like S3, allow users to add tags to the objects. This enables the users to better manage their files and filter them when needed.

https://docs.aws.amazon.com/AmazonS3/latest/userguide/tagging-managing.html

Your task is to implement a tagging system for files through which the user will directly interact with these APIs and add / remove / edit tags.

@alisonfung
Copy link
Contributor

I am working on this with @Cao1224 and @nehapinni.

@faisalsayed10
Copy link
Owner Author

Awesome

@alisonfung
Copy link
Contributor

After investigating the issue with my team, we have a few questions.

Since tagging is an S3 feature, does the issue intend for tags to only be available if S3 is the provider?
If this is the case, then we will need to enable/disable the tags UI depending on the current provider, correct?
Also to note is that Backblaze currently does not support object tagging through their S3 compatible API.

Please let us know any advice or guidance you have. Thank you!

@faisalsayed10
Copy link
Owner Author

faisalsayed10 commented Jul 8, 2023

Oh, I see. yeah, we can make it such that if tags are not supported, we disable it and show a message in the UI that they aren't supported. For the rest of them, we can add the tags. Also, please make sure that it is recreate-able for other buckets (like how addFile, deleteFile functions are written, we could have common functions like listTags, removeTags, updateTags etc. that we can redefine for different buckets)

Also for firebase, we could use file metadata to store tags - https://firebase.google.com/docs/storage/web/file-metadata

Just to be clear about the UI, the users should be able to see what tags a file has, and they should be able to add/remove those tags.

I hope this answers all your questions, lmk if there's anything else. Thanks!

@faisalsayed10
Copy link
Owner Author

Merged by #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeday labs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants