Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly missing quotes for schema in "Extracting the column information from postgres database for table" step #20

Closed
janpio opened this issue Feb 28, 2020 · 1 comment

Comments

@janpio
Copy link
Contributor

janpio commented Feb 28, 2020

See this output:

time="2020-02-28 14:21:57" level=debug msg="Extracting the column information from postgres database for table: public.\"authors\"" file="sql.go:164"
Extracting column information from tables  25% [===========>                                      ] (1/4) [0s:1s]time="2020-02-28 14:21:57" level=debug msg="Extracting the column information from postgres database for table: public.\"authors_blogs\"" file="sql.go:164"
Extracting column information from tables  50% [========================>                         ] (2/4) [0s:0s]time="2020-02-28 14:21:57" level=debug msg="Extracting the column information from postgres database for table: public.\"blogs\"" file="sql.go:164"
Extracting column information from tables  75% [====================================>             ] (3/4) [1s:0s]time="2020-02-28 14:21:58" level=debug msg="Extracting the column information from postgres database for table: public.\"posts\"" file="sql.go:164"
Extracting column information from tables 100% [==================================================] (4/4) [1s:0s]

The missing \" for public might indicate this might crash if someone has an uppercase schema name.

@faisaltheparttimecoder
Copy link
Owner

Fixed via ac23cf1 and released via https://github.com/pivotal-gss/mock-data/releases/tag/v2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants