Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git head testsuite fails with ruby3.2dev for some unavailable method #479

Closed
mtasaka opened this issue Nov 13, 2022 · 3 comments
Closed

Comments

@mtasaka
Copy link

mtasaka commented Nov 13, 2022

Fedora 38 is now preparing for upcoming ruby3.2 (which is expected to be released on 2022/Dec) and with ruby3.2dev (I've tried ruby/ruby@6bf458eefd ) fakefs git head ( v1.8.0 i.e. 0bfd95a ) test suite fails like:

Finished in 0.807165s, 905.6384 runs/s, 1819.9492 assertions/s.

  1) Failure:
FakeFSTest#test_wait_priority_method_in_file_is_in_fake_fs_file [/builddir/build/BUILD/GIT/fakefs/test/fakefs_test.rb:2065]:
wait_priority method is not available in File :(

  2) Failure:
FakeFSTest#test_timeout=_method_in_file_is_in_fake_fs_file [/builddir/build/BUILD/GIT/fakefs/test/fakefs_test.rb:2065]:
timeout= method is not available in File :(

  3) Failure:
FakeFSTest#test_timeout_method_in_file_is_in_fake_fs_file [/builddir/build/BUILD/GIT/fakefs/test/fakefs_test.rb:2065]:
timeout method is not available in File :(

731 runs, 1469 assertions, 3 failures, 0 errors, 1 skips

wait_priority is perhaps related with the following changes:
https://bugs.ruby-lang.org/issues/18655
ruby/ruby#6036

After the discussion, we will drop wait_priority, but others are accepted.

timeout= seems related to https://github.com/ruby/ruby/blob/bab8051d2d20a13f4aa26330a25e72ccec980f7a/NEWS.md?plain=1#L109

For now, just adding these unavailable methods to OMITTED_MRI_FILE_METHODS (

OMITTED_MRI_FILE_METHODS = [
) will meet the demand ?

@grosser grosser mentioned this issue Nov 14, 2022
@grosser
Copy link
Collaborator

grosser commented Nov 14, 2022

#480 should fix that

@grosser
Copy link
Collaborator

grosser commented Nov 14, 2022

1.9.0

@grosser grosser closed this as completed Nov 14, 2022
@mtasaka
Copy link
Author

mtasaka commented Nov 14, 2022

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants