New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): skip console messages containing 'deprecated' #1709
chore(test): skip console messages containing 'deprecated' #1709
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1709 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2249 2249
Lines 240573 240573
Branches 1095 1095
=======================================
Hits 239698 239698
Misses 854 854
Partials 21 21 |
Please fix the lint errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to improve the execution speed in CI (3.5mins -> 2.5mins), but it doesn't have that much of an impact for me locally.
The logs have been reduced from almost 30k logs to ~200 which is good, but I'm not sure this a good long term solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested before and after my changes
Both still don't really work better on my machine
The tests are absolutely bloated and run into timeouts
Co-authored-by: Shinigami <chrissi92@hotmail.de>
I don't know enough about how the tests works to figure out why they are so slow, however this change at least makes it possible to read the log output on GitHub.com easily. |
This is indeed a huge benefit 👌 |
running
pnpm run test
logs an enormous number of deprecation warnings. This makes it hard to review the output locally and in CI.vitest-dev/vitest#1700 shows a way to filter out specific logs, in this case anything containing "deprecated".