Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Add JSDoc descriptions #203

Closed
Shinigami92 opened this issue Jan 17, 2022 · 32 comments
Closed

EPIC: Add JSDoc descriptions #203

Shinigami92 opened this issue Jan 17, 2022 · 32 comments
Assignees
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature

Comments

@Shinigami92
Copy link
Member

Shinigami92 commented Jan 17, 2022

Clear and concise description of the problem

Most (if not all) of the functions already have JSDoc, but these are just simple e.g. @param <fieldName> without the descriptive text.
We found some documentation like #160, https://fakerjs.dev/api/datatype and e.g. these schema definitions that were just for generating documentation.

Suggested solution

We would like to write these messages to the JSDoc comments, so that IDEs like VSCode can provide them via tooltips.

Alternative

No response

Additional context

After this is done, we think that we can remove the schema definitions.

Module Assignees #PR Done
address.ts @mbokinala, @ST-DDT #230 ✔️
animal.ts @mbokinala #250, #417 ✔️
commerce.ts @ST-DDT #351 ✔️
company.ts @ST-DDT #423 ✔️
database.ts @ST-DDT #424 ✔️
datatype.ts @pkuczynski #337 ✔️
date.ts @ST-DDT #427 ✔️
fake.ts @ST-DDT #406 ✔️
finance.ts @ST-DDT #434 ✔️
git.ts @ST-DDT #435 ✔️
hacker.ts @ST-DDT #436 ✔️
helpers.ts @ST-DDT #442 ✔️
image.ts @ST-DDT #437 ✔️
internet.ts @ST-DDT #447 ✔️
lorem.ts @ST-DDT #458 ✔️
mersenne.ts @ST-DDT #438 ✔️
music.ts @ST-DDT #390 ✔️
name.ts @ST-DDT #391 ✔️
phone.ts @pkuczynski #397 ✔️
random.ts @pkuczynski @ST-DDT #408 #562 ✔️
system.ts @pkuczynski #298 ✔️
time.ts @pkuczynski #288 ✔️
unique.ts @ST-DDT #439 ✔️
vehicle.ts @pkuczynski #274 ✔️
word.ts @pkuczynski #273 ✔️
@Shinigami92 Shinigami92 added s: pending triage Pending Triage c: docs Improvements or additions to documentation c: feature Request for new feature help wanted Extra attention is needed and removed s: pending triage Pending Triage labels Jan 17, 2022
@github-actions
Copy link

Hello @Shinigami92. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!

@mbokinala
Copy link
Contributor

@Shinigami92 I can work on this

@import-brain
Copy link
Member

@Shinigami92 Please assign to @mbokinala, thanks

@MilosPaunovic MilosPaunovic removed the help wanted Extra attention is needed label Jan 18, 2022
@Shinigami92
Copy link
Member Author

Please not that it is very much to do in this PR. Maybe split it and multiple contributors can open PRs, communicating here or via Discord who is on which part or so.
That would also be easier to review.

@mbokinala
Copy link
Contributor

Maybe split it and multiple contributors can open PRs, communicating here or via Discord who is on which part or so.

Sounds good, shall we coordinate it on Discord?

@fzn0x
Copy link
Contributor

fzn0x commented Jan 19, 2022

Maybe split it and multiple contributors can open PRs, communicating here or via Discord who is on which part or so.

Sounds good, shall we coordinate it on Discord?

Yup we actively discussing everything about faker there :)

@pkuczynski
Copy link
Member

If you need some help, I can jump in... I am not using discord much, but I can follow on the comment here...

@Shinigami92
Copy link
Member Author

Take a look at #230 and #250
Just do exactly that for the other modules 🙂

@pkuczynski
Copy link
Member

Take a look at #230 and #250
Just do exactly that for the other modules 🙂

Is there a list whos working on what, so I can put my name on it and avoid duplicating work?

@Shinigami92
Copy link
Member Author

@ST-DDT
Copy link
Member

ST-DDT commented Feb 5, 2022

finance.ts will be my next one. #434

@ST-DDT
Copy link
Member

ST-DDT commented Feb 5, 2022

I git it. #435

@ST-DDT
Copy link
Member

ST-DDT commented Feb 5, 2022

hacker incoming.

@ST-DDT
Copy link
Member

ST-DDT commented Feb 5, 2022

I can imageine doing another file now. #437

@ST-DDT
Copy link
Member

ST-DDT commented Feb 5, 2022

I feel like a mersenneary right now. #438

@ST-DDT
Copy link
Member

ST-DDT commented Feb 5, 2022

I couldn't think of a unique sentence to write here, just now. #439

@ST-DDT
Copy link
Member

ST-DDT commented Feb 5, 2022

I would like to thank all our helpers that contributed their time to address these issues.
Once all PRs have been reviewed and merged, we can finally close this issue.
I will tackle the last unclaimed one now: helpers

@ST-DDT ST-DDT removed the good first issue Good for newcomers label Feb 5, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Feb 5, 2022

@pkuczynski Do you have time to create the jsdocs PRs for lorem and internet this week?

@pkuczynski
Copy link
Member

This week might be hard. Go for it. Random I did most, I can finish that one

@ST-DDT
Copy link
Member

ST-DDT commented Feb 7, 2022

Internet is now covered: #447

@ST-DDT
Copy link
Member

ST-DDT commented Feb 9, 2022

Lorem is covered by #458

@ST-DDT
Copy link
Member

ST-DDT commented Feb 25, 2022

I created the last PR for random.

@ST-DDT
Copy link
Member

ST-DDT commented Mar 1, 2022

Finally done

@ST-DDT ST-DDT closed this as completed Mar 1, 2022
@ST-DDT ST-DDT unpinned this issue Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature
Projects
None yet
Development

No branches or pull requests

7 participants