New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Add JSDoc descriptions #203
Comments
Hello @Shinigami92. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it! |
@Shinigami92 I can work on this |
@Shinigami92 Please assign to @mbokinala, thanks |
Please not that it is very much to do in this PR. Maybe split it and multiple contributors can open PRs, communicating here or via Discord who is on which part or so. |
Sounds good, shall we coordinate it on Discord? |
Yup we actively discussing everything about faker there :) |
If you need some help, I can jump in... I am not using discord much, but I can follow on the comment here... |
|
I |
|
I can |
I feel like a |
I couldn't think of a |
I would like to thank all our helpers that contributed their time to address these issues. |
@pkuczynski Do you have time to create the jsdocs PRs for lorem and internet this week? |
This week might be hard. Go for it. Random I did most, I can finish that one |
Internet is now covered: #447 |
Lorem is covered by #458 |
I created the last PR for |
Finally done |
Clear and concise description of the problem
Most (if not all) of the functions already have JSDoc, but these are just simple e.g.
@param <fieldName>
without the descriptive text.We found some documentation like #160, https://fakerjs.dev/api/datatype and e.g. these schema definitions that were just for generating documentation.
Suggested solution
We would like to write these messages to the JSDoc comments, so that IDEs like VSCode can provide them via tooltips.
Alternative
No response
Additional context
After this is done, we think that we can remove the schema definitions.
The text was updated successfully, but these errors were encountered: