Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve norwegian translations #1042

Merged
merged 1 commit into from Jun 9, 2022

Conversation

Johannes-Andersen
Copy link
Contributor

@Johannes-Andersen Johannes-Andersen commented Jun 8, 2022

Added a few missing Norwegian Bokmål translations that where missing

My first PR to the project, so let me know if I have done something stupid :)

@Johannes-Andersen Johannes-Andersen requested a review from a team as a code owner June 8, 2022 15:51
@xDivisionByZerox xDivisionByZerox added the c: locale Permutes locale definitions label Jun 8, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jun 8, 2022
@import-brain import-brain requested a review from a team June 8, 2022 16:36
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1042 (a46921a) into main (c5ac124) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #1042    +/-   ##
========================================
  Coverage   99.66%   99.66%            
========================================
  Files        2124     2135    +11     
  Lines      228224   229134   +910     
  Branches      990      989     -1     
========================================
+ Hits       227459   228366   +907     
- Misses        744      747     +3     
  Partials       21       21            
Impacted Files Coverage Δ
src/locales/nb_NO/color/human.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/color/index.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/commerce/index.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/index.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/science/chemicalElement.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/science/index.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/science/unit.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/word/adjective.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/word/conjunction.ts 100.00% <100.00%> (ø)
... and 3 more

ST-DDT
ST-DDT previously approved these changes Jun 8, 2022
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the translations using google and looks good to me.

@ST-DDT
Copy link
Member

ST-DDT commented Jun 8, 2022

Can you check why Github shows your commit as unverified?
grafik

@ST-DDT ST-DDT requested a review from a team June 8, 2022 22:59
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Jun 8, 2022
@Johannes-Andersen
Copy link
Contributor Author

Can you check why Github shows your commit as unverified?
grafik

Ah, I’ll get that fixed tomorrow. Didn’t have my hardware key with my GPG key plugged in so the commit did not get signed

@Johannes-Andersen
Copy link
Contributor Author

Can you check why Github shows your commit as unverified? grafik

Should be sorted now. All commits on the PR should be signed 👌🏻

@ST-DDT
Copy link
Member

ST-DDT commented Jun 9, 2022

Should be sorted now. All commits on the PR should be signed 👌🏻

Works as expected. Thanks!

@ST-DDT ST-DDT requested a review from a team June 9, 2022 11:12
@Shinigami92 Shinigami92 merged commit e071c78 into faker-js:main Jun 9, 2022
@Johannes-Andersen Johannes-Andersen deleted the nbNO-translations branch June 9, 2022 19:30
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants