-
-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch code option for SWIFT/BIC codes #1158
Comments
It should still be possible to call the function and get 8 or 11 as result so your test suit can handle both kind of data |
FFR: faker/src/modules/finance/index.ts Lines 412 to 414 in df9c650
|
Yeah, most of the functions with parameters use options objects, so we should keep it consistent and have one here as well. |
I fixed the bug in #1171, and if you accept it I can extend it with these additional parameters to control branch code generation... |
Hi Hanna, are you on this issue? I could take it, if you wish. Thank you for your help with the implementation fix! |
From bank.codes: "SWIFT codes are laid out in a standard format. You'll find 8 letters or digits for a standard SWIFT code, or 11 if you also have the branch code added. The last 3 digits which show the specific branch an account is held at are not always necessary."
Currently,
finance.bic()
uses a ternary operatorfaker/src/modules/finance/index.ts
Lines 412 to 414 in df9c650
I propose that we add a boolean
branchCode
parameter tofinance.bic()
to give users the ability to pick whether they want a standard SWIFT code or a code with the branch code at the end.The text was updated successfully, but these errors were encountered: