Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(finance): update Zambian Kwacha to new version #1393

Merged
merged 2 commits into from Sep 26, 2022
Merged

fix(finance): update Zambian Kwacha to new version #1393

merged 2 commits into from Sep 26, 2022

Conversation

AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt requested a review from a team as a code owner September 26, 2022 15:32
@xDivisionByZerox xDivisionByZerox added the c: locale Permutes locale definitions label Sep 26, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Sep 26, 2022
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022 •
edited

Codecov Report

Merging #1393 (9c6067d) into main (526906f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9c6067d differs from pull request most recent head db88707. Consider uploading reports for the commit db88707 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1393   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2163     2163           
  Lines      241303   241303           
  Branches     1014     1014           
=======================================
  Hits       240403   240403           
  Misses        879      879           
  Partials       21       21
Impacted Files Coverage Δ
src/locales/en/finance/currency.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Sep 26, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) September 26, 2022 18:57
@ST-DDT ST-DDT merged commit 115e859 into faker-js:main Sep 26, 2022
@AdriVanHoudt AdriVanHoudt deleted the patch-2 branch September 27, 2022 06:50
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
@AdriVanHoudt @wael-fadlallah
fix(finance): update Zambian Kwacha to new version (faker-js#1393)
3bf657b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@AdriVanHoudt AdriVanHoudt

Labels
c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdriVanHoudt @ST-DDT @import-brain @xDivisionByZerox