Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(company)!: remove hardcoded name fallback pattern #1451

Merged
merged 1 commit into from
Oct 14, 2022
Merged

refactor(company)!: remove hardcoded name fallback pattern #1451

merged 1 commit into from
Oct 14, 2022

Conversation

Minozzzi
Copy link
Contributor

Fixes: #1294

@Minozzzi Minozzzi requested a review from a team as a code owner October 14, 2022 23:23
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #1451 (4fed97c) into next (d3fb2c0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1451      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.02%     
==========================================
  Files        2164     2164              
  Lines      236816   236810       -6     
  Branches     1005      999       -6     
==========================================
- Hits       235918   235887      -31     
- Misses        876      901      +25     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/company/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 83.06% <0.00%> (-6.62%) ⬇️

@Shinigami92 Shinigami92 changed the title refactor(company/name): remove hardcoded fallback pattern refactor!(company): remove hardcoded name fallback pattern Oct 14, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: company Something is referring to the company module labels Oct 14, 2022
@Shinigami92 Shinigami92 changed the title refactor!(company): remove hardcoded name fallback pattern refactor(company)!: remove hardcoded name fallback pattern Oct 14, 2022
@Shinigami92 Shinigami92 merged commit b99ff71 into faker-js:next Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@Minozzzi Minozzzi

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Remove hardcoded fallback patterns from company.name
3 participants
@Minozzzi @ST-DDT @Shinigami92