Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internet): add options to url() #1480

Merged
merged 6 commits into from
Oct 26, 2022
Merged

feat(internet): add options to url() #1480

merged 6 commits into from
Oct 26, 2022

Conversation

import-brain
Copy link
Member

closes #1474

@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: internet Something is referring to the internet module labels Oct 23, 2022
@import-brain import-brain requested a review from a team as a code owner October 23, 2022 19:53
@import-brain import-brain self-assigned this Oct 23, 2022
@codecov
Copy link

codecov bot commented Oct 23, 2022 •
edited

Codecov Report

Merging #1480 (748cd77) into next (64b031a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1480   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2165     2165           
  Lines      237132   237147   +15     
  Branches     1015     1021    +6     
=======================================
+ Hits       236254   236285   +31     
+ Misses        857      841   -16     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/internet/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 90.47% <0.00%> (+4.23%) ⬆️

@import-brain @ST-DDT
Update src/modules/internet/index.ts
6aa6627 
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Shinigami92
Shinigami92 reviewed Oct 24, 2022
View reviewed changes
test/internet.spec.ts Outdated Show resolved Hide resolved
import-brain and others added 2 commits October 24, 2022 10:42
@ST-DDT ST-DDT merged commit 09e8356 into next Oct 26, 2022
@ST-DDT ST-DDT deleted the feat/url_opts branch October 26, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@import-brain import-brain

Labels
c: feature Request for new feature m: internet Something is referring to the internet module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

add options to faker.internet.url()
3 participants
@import-brain @ST-DDT @Shinigami92