feat(locale): update Korean color, date, location, word, company #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
reviewed
Oct 27, 2022
ST-DDT
added
p: 1-normal
ST-DDT
previously approved these changes
Oct 27, 2022
|
The values look good to me (checked via Google Translate), but there are some duplicates. |
thilllon
commented
Oct 28, 2022
thilllon
commented
Oct 28, 2022
I fixed. Take a look please. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1492 +/- ##
========================================
Coverage 99.63% 99.63%
========================================
Files 2165 2175 +10
Lines 237147 237647 +500
Branches 1021 1021
========================================
+ Hits 236285 236785 +500
Misses 841 841
Partials 21 21
|
Awesome. Thanks for your contribution. |
ST-DDT
previously approved these changes
Oct 28, 2022
…ondary_address, word.adjective, word.adverb, word.noun and extend company.suffix for Korean locale
import-brain
approved these changes
Oct 28, 2022
Shinigami92
approved these changes
Oct 28, 2022
ST-DDT
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Korean color.human, date.month, date.weekday, location.secondary_address, word.adjective, word.adverb, word.noun and extended Korean company.suffix.
For Koreans reading this, I know that adjectives and adverbs cannot be paired with English, grammatically strictly speaking. But I tried to choose words that made the most sense. 👍