Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add dv locale #1506

Merged
merged 5 commits into from
Nov 5, 2022
Merged

feat(locale): add dv locale #1506

merged 5 commits into from
Nov 5, 2022

Conversation

subbe
Copy link
Contributor

@subbe subbe commented Oct 31, 2022

Added locale for Dhivehi (dv) language

This will generate

  • male names
  • female names
  • colors
  • company names
  • dates
  • city names
  • lorem texts

@subbe subbe requested a review from a team October 31, 2022 08:48
@subbe subbe requested a review from a team as a code owner October 31, 2022 08:48
@ST-DDT
Copy link
Member

ST-DDT commented Oct 31, 2022

Wow a new language for our repo.
For everyone interested:

The language is native to The Maldives, Minicoy Island (Maliku) according to wikipedia.

Please note that it might take some days to review all files.

Thanks for your contribution.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1506 (b95a72d) into next (1452a59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             next    #1506     +/-   ##
=========================================
  Coverage   99.64%   99.64%             
=========================================
  Files        2175     2213     +38     
  Lines      237636   238633    +997     
  Branches     1013     1015      +2     
=========================================
+ Hits       236782   237782   +1000     
+ Misses        833      830      -3     
  Partials       21       21             
Impacted Files Coverage Δ
src/locale/dv.ts 100.00% <100.00%> (ø)
src/locales/dv/cell_phone/formats.ts 100.00% <100.00%> (ø)
src/locales/dv/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/dv/color/human.ts 100.00% <100.00%> (ø)
src/locales/dv/color/index.ts 100.00% <100.00%> (ø)
src/locales/dv/company/adjective.ts 100.00% <100.00%> (ø)
src/locales/dv/company/index.ts 100.00% <100.00%> (ø)
src/locales/dv/company/name_patterns.ts 100.00% <100.00%> (ø)
src/locales/dv/company/noun.ts 100.00% <100.00%> (ø)
src/locales/dv/company/suffix.ts 100.00% <100.00%> (ø)
... and 30 more

src/locales/dv/date/month.ts Outdated Show resolved Hide resolved
src/locales/dv/date/weekday.ts Outdated Show resolved Hide resolved
src/locales/dv/phone_number/formats.ts Show resolved Hide resolved
src/locales/dv/date/month.ts Show resolved Hide resolved
src/locales/dv/date/weekday.ts Show resolved Hide resolved
src/locales/dv/location/default_country.ts Show resolved Hide resolved
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Nov 3, 2022
@ST-DDT ST-DDT requested review from a team November 3, 2022 08:43
@ST-DDT ST-DDT merged commit 0b9989f into faker-js:next Nov 5, 2022
@subbe subbe deleted the add-dhivehi-locale branch November 6, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants