fix(git): adjust commitEntry to match git log output
#1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1539 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2214 2214
Lines 238701 238758 +57
Branches 1014 1015 +1
=======================================
+ Hits 237845 237902 +57
Misses 835 835
Partials 21 21
|
ST-DDT
changed the title
git log output
Shinigami92
reviewed
Nov 8, 2022
Shinigami92
approved these changes
Nov 8, 2022
import-brain
approved these changes
Nov 8, 2022
xDivisionByZerox
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1537
Fixes the test snapshots tests for
faker.git.commitEntryintroduced by #1512Fixes the current issues with our test snapshots for
faker.git.commitEntry()by changing the output to match the output ofgit log. That command uses theenlocale on all platforms (we were able to test on).To simplify the implementation and to retain the code readability the
commitDategeneration was moved to a separate method.