Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language #1548

Open
nicolasWD opened this issue Nov 11, 2022 · 14 comments
Open

Add language #1548

nicolasWD opened this issue Nov 11, 2022 · 14 comments
Assignees
Labels
c: feature Request for new feature m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug s: waiting for user interest Waiting for more users interested in this feature
Milestone

Comments

@nicolasWD
Copy link

Clear and concise description of the problem

I am looking to add random languages for a field "Spoken Languages"

Suggested solution

Under faker.name please add language, like spoken language (e.g. English, Chinese, Spanish)

or

in faker.random.locale() you could add the option to return language name instead of the 2 letter code only

Alternative

No response

Additional context

No response

@nicolasWD nicolasWD added the s: pending triage Pending Triage label Nov 11, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Nov 11, 2022

Sounds like an interesting proposal.

Do you need a list/one of all languages in the world or one of the languages in your country/state?
Are you willing to create a PR for that?

@ST-DDT ST-DDT added the s: awaiting more info Additional information are requested label Nov 11, 2022
@nicolasWD
Copy link
Author

nicolasWD commented Nov 11, 2022

For the specific project I am working on, I need multiple unique world language names (e.g. English, French).

Yes, I can open a PR for this. Under which branch should I create the PR?

@import-brain import-brain added c: feature Request for new feature s: needs decision Needs team/maintainer decision and removed s: pending triage Pending Triage s: awaiting more info Additional information are requested labels Nov 11, 2022
@nicolasWD
Copy link
Author

Ok, please let me know of the next steps.

@ST-DDT
Copy link
Member

ST-DDT commented Nov 11, 2022

This list might be a bit excessive:

See also here: https://github.com/faker-js/faker/blob/next/CONTRIBUTING.md

Please let us know, if you have any questions or anything is unclear.

@nicolasWD
Copy link
Author

Yes, I found Contributing a very nice and concise read. Will start immediately! Thank you!

@ST-DDT ST-DDT added p: 1-normal Nothing urgent m: location Something is referring to the location module s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Nov 11, 2022
@matthewmayer
Copy link
Contributor

Would you expect it to return "German" or "Deutsch" in the en locale? Might need to split into two methods for that, or add a parameter to determine if you expect the locale name of the language.

https://en.wikipedia.org/wiki/Linguonym

@ST-DDT
Copy link
Member

ST-DDT commented Nov 12, 2022

No, it will always return the name of the languages in the currently selected locale.
So in en it is German and in de it is Deutsch...

If you want it in another locale, switch to that.

@xDivisionByZerox
Copy link
Member

@nicolasWD Are you still working on that? Otherwise, I would label this with help wanted and unassign you so other people can take it.

@nicolasWD
Copy link
Author

I did start it and was struck with some personal issues/drama. I would still be happy to continue this as it would be my first contribution here. I will let you know soon, if anything changes.

@xDivisionByZerox
Copy link
Member

This is NOT scheduled for any specific release, so you are fine. Just wanted to know, so I can keep the tickets clean^^

@nicolasWD
Copy link
Author

@xDivisionByZerox thank you, I appreciate it

Copy link
Contributor

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@ST-DDT ST-DDT modified the milestones: vAnytime, vFuture Jan 25, 2024
@chrda81
Copy link

chrda81 commented Apr 16, 2024

+1

@ST-DDT
Copy link
Member

ST-DDT commented Apr 16, 2024

@chrda81 Please upvote the issue instead of posting +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug s: waiting for user interest Waiting for more users interested in this feature
Projects
No open projects
Status: Todo
Development

No branches or pull requests

6 participants