Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add free email domains for zh_CN #1555

Merged
merged 2 commits into from
Nov 20, 2022

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Nov 13, 2022

@matthewmayer matthewmayer requested a review from a team as a code owner November 13, 2022 10:38
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #1555 (bb8cadd) into next (73690e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1555   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2214     2216    +2     
  Lines      238815   238845   +30     
  Branches     1029     1029           
=======================================
+ Hits       237953   237983   +30     
  Misses        841      841           
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/zh_CN/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/internet/free_email.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/internet/index.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 added c: locale Permutes locale definitions m: internet Something is referring to the internet module labels Nov 13, 2022
@Shinigami92 Shinigami92 requested review from a team November 20, 2022 11:52
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Nov 20, 2022
@Shinigami92 Shinigami92 merged commit f241928 into faker-js:next Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: internet Something is referring to the internet module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants