feat(locate): add japanese company #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
reviewed
Nov 20, 2022
ST-DDT
added
p: 1-normal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1573 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 2216 2220 +4
Lines 238921 238959 +38
Branches 1040 1039 -1
==========================================
+ Hits 238062 238097 +35
- Misses 838 841 +3
Partials 21 21
|
ST-DDT
reviewed
Nov 20, 2022
|
@kiaking Hey my japanese friend 🙃 |
kiaking
approved these changes
Nov 21, 2022
Shinigami92
approved these changes
Nov 21, 2022
ST-DDT
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Japanese company.
I used this as a reference.
https://github.com/faker-ruby/faker/blob/main/lib/locales/ja/company.yml