Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add matrix of supported node versions #159

Closed
prisis opened this issue Jan 15, 2022 · 2 comments · Fixed by #179
Closed

ci: add matrix of supported node versions #159

prisis opened this issue Jan 15, 2022 · 2 comments · Fixed by #179
Assignees
@MohdImran001
Labels
good first issue Good for newcomers help wanted Extra attention is needed p: 3-urgent Fix and release ASAP
Milestone
v6.0 - Ensure Pro...

Comments

@prisis
Copy link
Member

prisis commented Jan 15, 2022

Check https://github.com/vitejs/vite/blob/main/.github/workflows/ci.yml#L27 how to do it
@prisis prisis added the s: pending triage Pending Triage label Jan 15, 2022
@Shinigami92 Shinigami92 added the c: feature Request for new feature label Jan 15, 2022
@prisis prisis added good first issue Good for newcomers help wanted Extra attention is needed c: chore PR that doesn't affect the runtime behavior and removed c: feature Request for new feature s: pending triage Pending Triage labels Jan 15, 2022
@github-actions
Copy link

Hello @prisis. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!

@Shinigami92 Shinigami92 mentioned this issue Jan 15, 2022
Merged
@prisis prisis added this to the v6.0.0 milestone Jan 16, 2022
@MohdImran001
Copy link
Contributor

@Shinigami92 Can I work on it ?

@MohdImran001 MohdImran001 mentioned this issue Jan 16, 2022
Merged
@Shinigami92 Shinigami92 added p: 3-urgent Fix and release ASAP and removed c: chore PR that doesn't affect the runtime behavior labels Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohdImran001 MohdImran001

Labels
good first issue Good for newcomers help wanted Extra attention is needed p: 3-urgent Fix and release ASAP
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging a pull request may close this issue.

ci: add node version matrix MohdImran001/faker
3 participants
@prisis @Shinigami92 @MohdImran001