Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(string): add special() method #1634

Merged
merged 5 commits into from
Dec 7, 2022

Conversation

notbrayton
Copy link
Contributor

@notbrayton notbrayton commented Dec 6, 2022

Added the string.special() method along with corresponding tests for issue #1467

p.s. I apologize for the poor commit messages, I messed up their format and content.

@notbrayton notbrayton requested a review from a team as a code owner December 6, 2022 06:23
@Shinigami92 Shinigami92 added c: feature Request for new feature m: string Something is referring to the string module labels Dec 6, 2022
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1634 (df2fa7e) into next (f1948bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1634   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2222     2222           
  Lines      240434   240495   +61     
  Branches     1064     1069    +5     
=======================================
+ Hits       239532   239593   +61     
  Misses        881      881           
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/string/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Dec 6, 2022
@ST-DDT ST-DDT requested review from a team December 6, 2022 08:56
@ST-DDT ST-DDT linked an issue Dec 6, 2022 that may be closed by this pull request
@ST-DDT
Copy link
Member

ST-DDT commented Dec 7, 2022

We merged a PR that accidentally causes this PR to fail. We will fix it asap.

@ST-DDT ST-DDT enabled auto-merge (squash) December 7, 2022 10:06
@ST-DDT ST-DDT merged commit 50fb72c into faker-js:next Dec 7, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Dec 7, 2022

Thanks for your contribution 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

New method: string.special
3 participants