Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): change country name from Holanda to official name #1669

Merged
merged 2 commits into from
Dec 18, 2022

Conversation

marcosvidolin
Copy link
Contributor

Change country name from Holland to official name Netherlands

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Dec 17, 2022
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #1669 (6442179) into next (27d41ee) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1669   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2227     2227           
  Lines      240254   240254           
  Branches     1055     1055           
=======================================
  Hits       239406   239406           
  Misses        827      827           
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/es/location/country.ts 100.00% <100.00%> (ø)
src/locales/es_MX/location/country.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/location/country.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT changed the title fix(locate): change country name from Holland to official name fix(locale): change country name from Holanda to official name Dec 17, 2022
@ST-DDT ST-DDT requested review from a team December 17, 2022 12:57
@ST-DDT ST-DDT enabled auto-merge (squash) December 17, 2022 19:16
@ST-DDT ST-DDT merged commit 4ce378c into faker-js:next Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants