fix(finance): update iso-3166-1 country codes for IBAN/BIC

[bmenant]

I had posted the issue #1261 on the original repository, followed by a pull request (from this branch).

To put it short: this simply update the list of ISO-3166-1 country codes [1] used for IBAN & BIC generations. As a matter of fact, some codes were nonexistent in the official specifications. Those have caused Faker.js to generate invalid IBAN and BIC codes (notably when checked against validator.js, for example).

FYI, as of today, I’m unable to run tests: Error: Cannot find module './lib'

[1] Both BIC (ISO-9362) and IBAN (ISO-13616) explicitly refers to ISO-3166-1.

---

It has also been suggested (here: #131) to use fake-numbers for IBAN generation. AFAIK, it uses a restricted list of country codes for IBAN generation (which I believe to be just fine). However, for BIC generation, fake-numbers uses a random string of 2 letters as a country code (which are unlikely to ever produce a valid BIC code IMHO).

[netlify]

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: c7beecf

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e3f14654ea5200086836b3

😎 Browse the preview: https://deploy-preview-168--vigilant-wescoff-04e480.netlify.app

[Shinigami92]

To tun test you have to run npm run build to generate lib content

[bmenant]

Rebased on v6.0.0-alpha.5 and updated tests.

[bmenant]

I think it’s out of scope over here, but you might consider refactoring countries data (I suppose there are other places Faker uses these).

You might also consider adding a dependencies for those, such as unicode-org/cldr-json, annexare/Countries or node-i18n-iso-countries.

[ST-DDT]

The ISO page seems to still be down. I will review it once it is back up again.

[hertzg]

@ST-DDT FYI ISO page seems to be back up

[ST-DDT]

XK doesn't appear in the iso-list, but i found multiple references to it in some other online references, which I would consider good enough.
I also checked the code regarding the usage of the iso codes and it is only used to generate bics so it should be safe.

[bmenant]

Rebased and updated tests as suggested by @Shinigami92

I had got a new failure in finance.spec.ts in a seed/bic test. I don’t know where those seeded values come from since they are hard-coded, but I had to change one of the BIC code (LT to LY). Since the order and the number of country codes has changed, it is likely that the country code selected for this particular seeding value has changed as well. Please let me know if I’m wrong.

[codecov]

Codecov Report

Merging #168 (f34c2f2) into main (af3f99e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      176483   176466      -17     
  Branches      905      905              
==========================================
- Hits       175303   175286      -17     
  Misses       1124     1124              
  Partials       56       56              

Impacted Files	Coverage Δ
src/iban.ts	100.00% <100.00%> (ø)

[Shinigami92]

(LT to LY).

This happened because you deleted some entries from the definitions, so the indexes changed. The values are "fetched" from the definitions via arrayElement which uses datatype.number as index.
So everything is okay 👌

[bmenant]

@Shinigami92 You reassigned myself, is there anything I can do so far? 🙂

[Shinigami92]

Nope, we just may have another workflow then you expect
We have a big issue/pr board: https://github.com/orgs/faker-js/projects/2/views/9
And there we can see who is or has worked on something, it's mostly the same as the author of a PR