Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(string): nanoid #1716

Merged
merged 5 commits into from
Jan 9, 2023
Merged

feat(string): nanoid #1716

merged 5 commits into from
Jan 9, 2023

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox commented Jan 8, 2023 •
edited by ST-DDT

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature s: accepted Accepted feature / Confirmed bug m: string Something is referring to the string module labels Jan 8, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team January 8, 2023 12:22
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner January 8, 2023 12:22
@xDivisionByZerox xDivisionByZerox self-assigned this Jan 8, 2023
@xDivisionByZerox xDivisionByZerox linked an issue Jan 8, 2023 that may be closed by this pull request
Add nanoid for uuid alternatives #1426
Closed
@xDivisionByZerox xDivisionByZerox changed the title Feat/string/nano feat(string): nanoid Jan 8, 2023
@codecov
Copy link

codecov bot commented Jan 8, 2023 •
edited

Codecov Report

Merging #1716 (8c86bd7) into next (27dff93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1716   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2336     2336           
  Lines      241081   241123   +42     
  Branches     1095     1102    +7     
=======================================
+ Hits       240199   240241   +42     
  Misses        861      861           
  Partials       21       21
Impacted Files Coverage Δ
src/modules/string/index.ts 100.00% <100.00%> (ø)

ST-DDT
ST-DDT requested changes Jan 8, 2023
View reviewed changes
test.ts Outdated Show resolved Hide resolved
src/modules/string/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Jan 8, 2023
@ST-DDT ST-DDT requested a review from a team January 8, 2023 14:20
@ST-DDT ST-DDT mentioned this pull request Jan 8, 2023
Merged
Shinigami92
Shinigami92 approved these changes Jan 9, 2023
View reviewed changes
src/modules/string/index.ts Show resolved Hide resolved
@ST-DDT ST-DDT merged commit 099e76c into next Jan 9, 2023
@ST-DDT ST-DDT deleted the feat/string/nano-id branch January 9, 2023 18:59
@xDivisionByZerox xDivisionByZerox mentioned this pull request Jan 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: feature Request for new feature m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Add nanoid for uuid alternatives
4 participants
@xDivisionByZerox @ST-DDT @Shinigami92 @import-brain