Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Random Zodiac Signs #175

Closed
luciferreeves opened this issue Jan 16, 2022 · 0 comments · Fixed by #182
Closed

Add Random Zodiac Signs #175

luciferreeves opened this issue Jan 16, 2022 · 0 comments · Fixed by #182
Assignees
@ST-DDT
Labels
c: feature Request for new feature needs documentation Documentations are needed p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts
Milestone
v8.x

Comments

@luciferreeves
Copy link
Contributor

Clear and concise description of the problem

We can add random zodiac signs. We can also use the date.past() function to generate a random birthday. We can also get the zodiac sign based on birthdate in wherever random details are generated.

Suggested solution

Do a new module for zodiac signs. The birthday module can be appended to the date module itself.

Alternative

No response

Additional context

No response
@luciferreeves luciferreeves added the s: pending triage Pending Triage label Jan 16, 2022
@luciferreeves luciferreeves changed the title Add Random Zodiac Signs + Birthday Add Random Zodiac Signs + Birthdays Jan 16, 2022
@Shinigami92 Shinigami92 added the c: feature Request for new feature label Jan 16, 2022
@github-actions github-actions bot removed the s: pending triage Pending Triage label Jan 16, 2022
@import-brain import-brain added the needs documentation Documentations are needed label Jan 16, 2022
@luciferreeves luciferreeves mentioned this issue Jan 17, 2022
Merged
@ST-DDT ST-DDT changed the title Add Random Zodiac Signs + Birthdays Add Random Zodiac Signs Sep 8, 2022
@ST-DDT ST-DDT self-assigned this Sep 8, 2022
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: feature Request for new feature needs documentation Documentations are needed p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

feat(person): add zodiacSign() luciferreeves/faker
4 participants
@ST-DDT @Shinigami92 @luciferreeves @import-brain