Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): replace Ð with Đ in hr and vi #1810

Merged
merged 2 commits into from
Feb 3, 2023
Merged

fix(locale): replace Ð with Đ in hr and vi #1810

merged 2 commits into from
Feb 3, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #1800

Replaces Ð with Đ in hr and vi

Removes some resultant duplicates in vi

@matthewmayer matthewmayer requested a review from a team as a code owner February 2, 2023 15:49
@codecov
Copy link

codecov bot commented Feb 2, 2023 •
edited

Codecov Report

Merging #1810 (ca71118) into next (d35da05) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1810   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2346     2346           
  Lines      235115   235103   -12     
  Branches     1132     1132           
=======================================
- Hits       234250   234247    -3     
+ Misses        843      834    -9     
  Partials       22       22
Impacted Files Coverage Δ
src/locales/hr/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/hr/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/vi/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/vi/person/male_first_name.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 93.78% <0.00%> (+2.66%) ⬆️

@matthewmayer matthewmayer changed the title replace Ð with Đ in hr and vi chore(locales): replace Ð with Đ in hr and vi Feb 2, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions c: bug Something isn't working labels Feb 2, 2023
@ST-DDT ST-DDT requested review from a team February 2, 2023 23:13
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Feb 2, 2023
@Shinigami92 Shinigami92 changed the title chore(locales): replace Ð with Đ in hr and vi fix(locale): replace Ð with Đ in hr and vi Feb 3, 2023
@Shinigami92 Shinigami92 merged commit ff53587 into faker-js:next Feb 3, 2023
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
@matthewmayer
fix(locale): replace Ð with Đ in hr and vi (faker-js#1810)
6cb0dbc
This was referenced Mar 14, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: bug Something isn't working c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Letter "Đ" in latin while using the hr locale is incorrect
4 participants
@matthewmayer @ST-DDT @Shinigami92 @import-brain