Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git): commitEntry normalize user #1813

Merged
merged 2 commits into from
Feb 4, 2023
Merged

fix(git): commitEntry normalize user #1813

merged 2 commits into from
Feb 4, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Feb 3, 2023 •
edited

fixes #1803

supersedes #1806

@Shinigami92 Shinigami92 added the c: bug Something isn't working label Feb 3, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 3, 2023 13:56
@Shinigami92 Shinigami92 self-assigned this Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023 •
edited

Codecov Report

Merging #1813 (c5cfc82) into next (8e4526d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1813   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2346     2346           
  Lines      235497   235500    +3     
  Branches     1137     1138    +1     
=======================================
+ Hits       234622   234635   +13     
+ Misses        853      843   -10     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/git/index.ts 100.00% <100.00%> (ø)
src/internal/mersenne/twister.ts 96.00% <0.00%> (-0.31%) ⬇️
src/modules/location/index.ts 98.70% <0.00%> (-0.22%) ⬇️
src/modules/internet/user-agent.ts 91.42% <0.00%> (+3.84%) ⬆️

@ST-DDT ST-DDT added p: 2-high Fix main branch c: test labels Feb 4, 2023
@ST-DDT ST-DDT requested review from a team February 4, 2023 00:05
@Shinigami92 Shinigami92 merged commit 667599d into next Feb 4, 2023
@Shinigami92 Shinigami92 deleted the fix-commit-entry branch February 4, 2023 20:57
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
@Shinigami92 @matthewmayer
fix(git): commitEntry normalize user (faker-js#1813)
ea6c511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working c: test p: 2-high Fix main branch
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

CI failure in git.commitEntry test
4 participants
@Shinigami92 @ST-DDT @import-brain @xDivisionByZerox