Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add state and state_abbr to cz #1847

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox commented Feb 16, 2023

Fill the states dataset for the locale cz.
In the Czech Republic "states" are called "regions". They are not the same but serve the same purpose for our data.


@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Feb 16, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team February 16, 2023 13:22
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner February 16, 2023 13:22
@xDivisionByZerox xDivisionByZerox self-assigned this Feb 16, 2023
@xDivisionByZerox
Copy link
Member Author

I was not able to find anything regarding state abbreviations. Should I simply copy the existing dataset in that case?

@xDivisionByZerox xDivisionByZerox changed the title locale(cz): add states feat(locale): add states to cz Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1847 (19b96bb) into next (085562f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1847      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2357     2357              
  Lines      236856   236875      +19     
  Branches     1229     1226       -3     
==========================================
+ Hits       235974   235987      +13     
- Misses        860      866       +6     
  Partials       22       22              
Impacted Files Coverage Δ
src/locales/cz/location/state.ts 100.00% <100.00%> (ø)
src/locales/cz/location/state_abbr.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

test/all_functional.spec.ts Outdated Show resolved Hide resolved
@ST-DDT
Copy link
Member

ST-DDT commented Feb 16, 2023

I was not able to find anything regarding state abbreviations. Should I simply copy the existing dataset in that case?

Instead of copying it you can import it and export it afterwards (with a comment why).

@xDivisionByZerox xDivisionByZerox changed the title feat(locale): add states to cz feat(locale): add state and state_abbr to cz Feb 16, 2023
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed c: feature Request for new feature labels Feb 22, 2023
@ST-DDT ST-DDT requested a review from a team February 22, 2023 23:56
@ST-DDT ST-DDT requested a review from Shinigami92 March 16, 2023 22:58
@ST-DDT ST-DDT enabled auto-merge (squash) March 17, 2023 22:11
@ST-DDT ST-DDT merged commit f6c8ca3 into next Mar 17, 2023
@Shinigami92 Shinigami92 deleted the locale/cz/add-states branch March 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants