Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(company)!: rename bs to buzz #1860

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Conversation

Shinigami92
Copy link
Member

references #1346

@Shinigami92 Shinigami92 added the deprecation A deprecation was made in the PR label Feb 20, 2023
@Shinigami92 Shinigami92 self-assigned this Feb 20, 2023
@Shinigami92
Copy link
Member Author

Shinigami92 commented Feb 20, 2023

#1346 (comment)

Team Decision: Company

bs should probably be deprecated

Yes!

Did we had a reason for just removing it?
What should I write in the proposed of deprecated?
Or do we just want to rename it to e.g. buzzWord?

bsAdjective should probably be merged into catchPhraseAdjective and deprecate
bsBuzz should probably be called buzzWord (is that correctly written?)
bsNoun should probably be merged into catchPhraseNoun and deprecated

Replace bs* with buzz* and improve JSDocs (buzz = manager language, catchPhrase = user language).

Open TODO:

  • improve JSDocs (buzz = manager language, catchPhrase = user language)

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #1860 (2b101bc) into next (0f98518) will increase coverage by 0.00%.
The diff coverage is 93.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1860   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2355     2355           
  Lines      236323   236403   +80     
  Branches     1150     1156    +6     
=======================================
+ Hits       235446   235538   +92     
+ Misses        855      843   -12     
  Partials       22       22           
Impacted Files Coverage Δ
src/definitions/company.ts 0.00% <0.00%> (ø)
src/locales/el/company/buzz_adjective.ts 100.00% <ø> (ø)
src/locales/el/company/buzz_noun.ts 100.00% <ø> (ø)
src/locales/el/company/buzz_verb.ts 100.00% <ø> (ø)
src/locales/en/company/buzz_adjective.ts 100.00% <ø> (ø)
src/locales/en/company/buzz_noun.ts 100.00% <ø> (ø)
src/locales/en/company/buzz_verb.ts 100.00% <ø> (ø)
src/locales/es_MX/company/buzz_adjective.ts 100.00% <ø> (ø)
src/locales/es_MX/company/buzz_noun.ts 100.00% <ø> (ø)
src/locales/es_MX/company/buzz_verb.ts 100.00% <ø> (ø)
... and 22 more

@Shinigami92 Shinigami92 marked this pull request as ready for review February 21, 2023 08:54
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 21, 2023 08:54
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Feb 21, 2023
@xDivisionByZerox
Copy link
Member

Did we had a reason for just removing it?
What should I write in the proposed of deprecated?
Or do we just want to rename it to e.g. buzzWord?

It was more important to get rid of the bs function as it can be considered unprofessional. Reading it's implementation buzzWordmakes sense.

src/definitions/company.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Feb 21, 2023
@ST-DDT ST-DDT requested a review from a team February 21, 2023 11:25
@Shinigami92 Shinigami92 merged commit 5f95aca into next Feb 21, 2023
@Shinigami92 Shinigami92 deleted the rename-company-bs-to-buzz branch February 21, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants