Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(random): remove deprecated method usage #1865

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 21, 2023

Fixed the calling of the method deprecated in #1860.

@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: random Something is referring to the random module labels Feb 21, 2023
@ST-DDT ST-DDT requested review from a team February 21, 2023 20:13
@ST-DDT ST-DDT self-assigned this Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #1865 (67ae8d7) into next (5f95aca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1865   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2355     2355           
  Lines      236403   236403           
  Branches     1154     1153    -1     
=======================================
+ Hits       235528   235531    +3     
+ Misses        853      850    -3     
  Partials       22       22           
Impacted Files Coverage Δ
src/modules/random/index.ts 99.13% <100.00%> (ø)
src/modules/internet/user-agent.ts 89.94% <0.00%> (+0.88%) ⬆️

@ST-DDT ST-DDT requested review from a team February 21, 2023 21:52
@Shinigami92 Shinigami92 merged commit 25bd847 into next Feb 22, 2023
@Shinigami92 Shinigami92 deleted the fix/random/word/remove-deprecated-method-usage branch February 22, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working m: random Something is referring to the random module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants