Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct types field #1878

Merged
merged 3 commits into from
Feb 28, 2023
Merged

fix: correct types field #1878

merged 3 commits into from
Feb 28, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Feb 26, 2023

fixing: https://publint.dev/@faker-js/faker@7.6.0

There is no index.d.ts
Everything is packaged into the dist folder
This might only affect users using TS + an old npm version that doesn't know the exports field

@Shinigami92 Shinigami92 added the c: bug Something isn't working label Feb 26, 2023
@Shinigami92 Shinigami92 self-assigned this Feb 26, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 26, 2023 16:41
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #1878 (30b64ac) into next (e6f949b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1878      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.01%     
==========================================
  Files        2355     2355              
  Lines      236763   236763              
  Branches     1157     1155       -2     
==========================================
- Hits       235922   235903      -19     
- Misses        819      838      +19     
  Partials       22       22              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 88.16% <0.00%> (-6.22%) ⬇️
src/modules/location/index.ts 98.92% <0.00%> (+0.21%) ⬆️

@ST-DDT
Copy link
Member

ST-DDT commented Feb 26, 2023

I found this commit, that "reverted" your change:
c704e36
Any idea why? Is it fixed?

@Shinigami92
Copy link
Member Author

I found this commit, that "reverted" your change: c704e36 Any idea why? Is it fixed?

I don't remember everything 9 month ago, but see my comment #979 (review)
It looks like only parts of the PRs were correct, but other parts are wrongly reverted

At Vue Amsterdam 2023 I learned a bit more about package.json and how to manage it + using https://publint.dev/
So I'm not sure if my knowledge is comparable anymore with my knowledge back then 9 month ago
Thanks a lot to @bluwy

@bluwy
Copy link

bluwy commented Feb 27, 2023

Actually I think before, this might work too as you had the typesVersion config that remaps the type definition, but going forward with this PR should still be safe too (and probably less confusing in the future). I find https://github.com/andrewbranch/example-subpath-exports-ts-compat/tree/main/examples/node_modules/types-versions-wildcards to be a great example of understanding how it works.

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Feb 27, 2023
@ST-DDT ST-DDT requested review from a team February 27, 2023 14:12
@ST-DDT ST-DDT enabled auto-merge (squash) February 28, 2023 18:14
@ST-DDT ST-DDT merged commit 956a15f into next Feb 28, 2023
@ST-DDT ST-DDT deleted the fix-types-in-package-json branch February 28, 2023 18:45
Shinigami92 added a commit that referenced this pull request Mar 23, 2023
@bluwy bluwy mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants