Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(currency): modernise currency list for 2023 #1880

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Feb 27, 2023

fix #1879

Removals

  • CUC (Cuban Peso Convertible, phased out 2021)
  • EEK (Estonian kroon, replaced by EUR in 2010)
  • HKR (Croatian Kuna, replace by EUR in 2023)
  • LTL (Lithuanian litas, replaced by EUR in 2015)
  • LVL (Latvian lats, replaced by EUR in 2013)
  • SVC (El Savador colon, replaced by USD in 2001)
  • XAG, XAU, XPD, XPT - precious metals
  • XTS - testing code
  • XBA, XBB, XBC, XBD - bond market units
  • XDR - special drawing rights
  • XFU - special settlement currency withdrawn 1990

Changes

  • MRO (Mauritanian ouguiya, replaced by MRU in 2018)
  • SLL (Sierra Leonean leone, replaced by SLE in 2022)

Additions

  • SSP (South Sudanese pound, introduced 2011)

@matthewmayer matthewmayer requested a review from a team as a code owner February 27, 2023 16:41
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1880 (1f60225) into next (59157a4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1880      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.01%     
==========================================
  Files        2355     2355              
  Lines      236843   236763      -80     
  Branches     1159     1155       -4     
==========================================
- Hits       236002   235908      -94     
- Misses        819      833      +14     
  Partials       22       22              
Impacted Files Coverage Δ
src/locales/en/finance/currency.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 89.64% <0.00%> (-4.15%) ⬇️

@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label Feb 27, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Feb 27, 2023
@ST-DDT ST-DDT requested a review from a team February 27, 2023 22:02
@ST-DDT ST-DDT merged commit e6f949b into faker-js:next Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update en currency list
5 participants