Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discord link #1891

Merged
merged 1 commit into from
Mar 4, 2023
Merged

fix: discord link #1891

merged 1 commit into from
Mar 4, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Mar 3, 2023 •
edited

closes #1890

@Shinigami92 Shinigami92 changed the title Update netlify.toml fix: discord link Mar 3, 2023
@Shinigami92 Shinigami92 self-assigned this Mar 3, 2023
@Shinigami92 Shinigami92 added the c: bug Something isn't working label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1891 (2341745) into next (f5b1c5a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1891      +/-   ##
==========================================
- Coverage   99.64%   99.62%   -0.02%     
==========================================
  Files        2355     2355              
  Lines      236763   236763              
  Branches     1157     1151       -6     
==========================================
- Hits       235916   235885      -31     
- Misses        825      856      +31     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 82.84% <0.00%> (-9.18%) ⬇️

@Shinigami92 Shinigami92 marked this pull request as ready for review March 3, 2023 20:28
@Shinigami92 Shinigami92 requested a review from a team March 3, 2023 20:28
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 3, 2023 20:28
@ST-DDT ST-DDT enabled auto-merge (squash) March 3, 2023 23:07
@ST-DDT ST-DDT requested review from a team March 3, 2023 23:08
@ST-DDT ST-DDT added p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug labels Mar 3, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Mar 3, 2023

Do we have to backport this to the v7 branch so it will be picked up by netlify?

@Shinigami92
Copy link
Member Author

Do we have to backport this to the v7 branch so it will be picked up by netlify?

Oh, good point. Yes maybe we need to do that 🤔

@ST-DDT ST-DDT merged commit 8a97cac into next Mar 4, 2023
@Shinigami92 Shinigami92 deleted the Shinigami92-patch-1 branch March 4, 2023 15:37
@matthewmayer matthewmayer mentioned this pull request Mar 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Can't join Discord community
3 participants
@Shinigami92 @ST-DDT @xDivisionByZerox