Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more discord links #1893

Merged
merged 1 commit into from
Mar 5, 2023
Merged

fix: more discord links #1893

merged 1 commit into from
Mar 5, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Mar 5, 2023 •
edited

Continuation of #1890 / #1891

  • missed an additional link
  • should use 302 not 301 links if the links might change at some point

@matthewmayer matthewmayer marked this pull request as ready for review March 5, 2023 03:45
@matthewmayer matthewmayer requested a review from a team March 5, 2023 03:45
@matthewmayer matthewmayer requested a review from a team as a code owner March 5, 2023 03:45
@codecov
Copy link

codecov bot commented Mar 5, 2023 •
edited

Codecov Report

Merging #1893 (f306fd7) into next (8592928) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1893      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.01%     
==========================================
  Files        2355     2355              
  Lines      236763   236763              
  Branches     1157     1154       -3     
==========================================
- Hits       235917   235910       -7     
- Misses        824      831       +7     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 90.23% <0.00%> (-2.08%) ⬇️

@matthewmayer matthewmayer self-assigned this Mar 5, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) March 5, 2023 08:28
@ST-DDT ST-DDT requested review from Shinigami92 and a team March 5, 2023 08:29
@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent labels Mar 5, 2023
@ST-DDT ST-DDT merged commit f948e2e into faker-js:next Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92

Assignees

@matthewmayer matthewmayer

Labels
c: bug Something isn't working p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewmayer @ST-DDT @xDivisionByZerox