Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide enums for color values #1910

Merged
merged 4 commits into from
Mar 14, 2023
Merged

feat: provide enums for color values #1910

merged 4 commits into from
Mar 14, 2023

Conversation

Shinigami92
Copy link
Member

Extracted from #1748 (comment)

@Shinigami92 Shinigami92 added the c: feature Request for new feature label Mar 7, 2023
@Shinigami92 Shinigami92 self-assigned this Mar 7, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 7, 2023 16:55
@Shinigami92 Shinigami92 mentioned this pull request Mar 7, 2023
Merged
@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited

Codecov Report

Merging #1910 (631b954) into next (b584038) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 631b954 differs from pull request most recent head 4079e4a. Consider uploading reports for the commit 4079e4a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1910      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2357     2356       -1     
  Lines      236564   236575      +11     
  Branches     1196     1192       -4     
==========================================
+ Hits       235688   235697       +9     
- Misses        854      856       +2     
  Partials       22       22
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/modules/color/index.ts 99.79% <100.00%> (+<0.01%) ⬆️

... and 6 files with indirect coverage changes

ST-DDT
ST-DDT requested changes Mar 7, 2023
View reviewed changes
src/modules/color/index.ts Outdated Show resolved Hide resolved
src/modules/color/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: color Something is referring to the color module and removed c: feature Request for new feature labels Mar 7, 2023
xDivisionByZerox
xDivisionByZerox reviewed Mar 8, 2023
View reviewed changes
src/modules/color/index.ts Show resolved Hide resolved
src/modules/color/index.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested review from ST-DDT, xDivisionByZerox and a team March 8, 2023 16:08
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 14, 2023 17:28
@Shinigami92 Shinigami92 merged commit a001090 into next Mar 14, 2023
@ST-DDT ST-DDT deleted the feat-convert-color-values-to-enum branch March 20, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: color Something is referring to the color module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shinigami92 @ST-DDT @xDivisionByZerox