Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): fix pt_PT street addresses #1911

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Mar 7, 2023

There are some weird formats that don't get parsed correctly in pt_PT street.ts file

Before:

fakerPT_PT.location.streetAddress() //N### 03

After

fakerPT_PT.location.streetAddress() // Avenida Gustavo Campos 3

also added secondary address formats with help from https://ling-app.com/pt/portuguese-addresses/

@matthewmayer matthewmayer changed the title locale: fix PT_PT street addresses fix(locale): fix PT_PT street addresses Mar 7, 2023
@matthewmayer matthewmayer changed the title fix(locale): fix PT_PT street addresses fix(locale): fix pt_PT street addresses Mar 7, 2023
@matthewmayer matthewmayer marked this pull request as ready for review March 7, 2023 17:17
@matthewmayer matthewmayer requested a review from a team as a code owner March 7, 2023 17:17
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1911 (1b4ea0a) into next (bb72a66) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1911   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2356     2357    +1     
  Lines      236565   236564    -1     
  Branches     1191     1196    +5     
=======================================
+ Hits       235680   235694   +14     
+ Misses        863      848   -15     
  Partials       22       22           
Impacted Files Coverage Δ
src/locales/pt_PT/location/street.ts 100.00% <ø> (ø)
src/locales/pt_PT/location/index.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/location/secondary_address.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/location/street_address.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Mar 7, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Mar 7, 2023
@ST-DDT ST-DDT requested review from a team March 7, 2023 21:15
@ST-DDT ST-DDT enabled auto-merge (squash) March 11, 2023 19:37
@ST-DDT ST-DDT merged commit 8f0abd3 into faker-js:next Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants