Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): az company name_patterns return undefined in name #1914

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

matthewmayer
Copy link
Contributor

Before:

fakerAZ.company.name() // ASC undefinedundefined

After:

fakerAZ.company.name() // ASC Bəxtiyar

This is similar to #1911, some az company/name_patterns reference company.suffix but thats empty

@matthewmayer matthewmayer requested a review from a team as a code owner March 8, 2023 11:45
@matthewmayer matthewmayer self-assigned this Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1914 (990c592) into next (6ba21c6) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1914   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2356     2356           
  Lines      236570   236565    -5     
  Branches     1195     1195           
=======================================
- Hits       235697   235695    -2     
+ Misses        851      848    -3     
  Partials       22       22           
Impacted Files Coverage Δ
src/locales/az/company/name_patterns.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label Mar 8, 2023
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Mar 8, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) March 11, 2023 19:36
@ST-DDT ST-DDT merged commit bb72a66 into faker-js:next Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants