Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): split zh_TW first_names by gender #1941

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Mar 17, 2023

Ensures that faker.person.fullName() works properly for zh_TW

ref #1677

Before:

fakerZH_TW.person.fullName() //'郭Franklin'

After:

fakerZH_TW.person.fullName() //'唐子騫'

@matthewmayer matthewmayer requested a review from a team as a code owner March 17, 2023 03:04
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1941 (dad5229) into next (241d11d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head dad5229 differs from pull request most recent head 51429cf. Consider uploading reports for the commit 51429cf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1941      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2354     2359       +5     
  Lines      236557   236889     +332     
  Branches     1228     1227       -1     
==========================================
+ Hits       235683   236008     +325     
- Misses        852      859       +7     
  Partials       22       22              
Impacted Files Coverage Δ
src/locales/zh_TW/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/person/index.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/person/male_first_name.ts 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Mar 17, 2023
@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module and removed c: bug Something isn't working labels Mar 17, 2023
@ST-DDT ST-DDT requested review from a team March 17, 2023 22:26
@ST-DDT ST-DDT enabled auto-merge (squash) March 20, 2023 18:47
@ST-DDT ST-DDT merged commit 4e97200 into faker-js:next Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants