Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert types field #1966

Merged
merged 3 commits into from
Mar 23, 2023
Merged

fix: revert types field #1966

merged 3 commits into from
Mar 23, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Mar 23, 2023

This reverts commit 956a15f.

This had broken the whole package!


@bluwy

  • If we remove the field it is not working
  • If we change the field to something else it is also not working
  • Only "types": "index.d.ts" is working here

Do you know anything about that? Why did publint reported this as invalid? Or even: what is going on here?

@Shinigami92 Shinigami92 added the c: bug Something isn't working label Mar 23, 2023
@Shinigami92 Shinigami92 self-assigned this Mar 23, 2023
@Shinigami92 Shinigami92 added the p: 3-urgent Fix and release ASAP label Mar 23, 2023
@Shinigami92 Shinigami92 changed the title Revert "fix: correct types field (#1878)" fix: revert types field Mar 23, 2023
@Shinigami92 Shinigami92 marked this pull request as ready for review March 23, 2023 10:57
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 23, 2023 10:57
@Shinigami92 Shinigami92 requested review from xDivisionByZerox, ST-DDT and a team March 23, 2023 10:57
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1966 (880556b) into next (4490a9e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1966      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2384     2384              
  Lines      238992   238992              
  Branches     1231     1227       -4     
==========================================
- Hits       238127   238110      -17     
- Misses        843      860      +17     
  Partials       22       22              

see 1 file with indirect coverage changes

@bluwy
Copy link

bluwy commented Mar 23, 2023

I suppose it was working because #1878 (comment) was true. That the typesVersion config is remapping it. I haven't took that into account when linting 😬 Good to know though that this doesn't work.

@ST-DDT ST-DDT requested review from a team March 23, 2023 12:50
@ST-DDT ST-DDT added the c: infra Changes to our infrastructure or project setup label Mar 23, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) March 23, 2023 16:56
@ST-DDT ST-DDT merged commit 9dcf83f into next Mar 23, 2023
@ST-DDT ST-DDT deleted the revert-types-field branch March 23, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: infra Changes to our infrastructure or project setup p: 3-urgent Fix and release ASAP
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants