Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image): use seeded picsum #1968

Merged
merged 6 commits into from
Mar 30, 2023
Merged

fix(image): use seeded picsum #1968

merged 6 commits into from
Mar 30, 2023

Conversation

Shinigami92
Copy link
Member

closes #1964

@Shinigami92 Shinigami92 added the c: bug Something isn't working label Mar 23, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 23, 2023 14:00
@Shinigami92 Shinigami92 self-assigned this Mar 23, 2023
@Shinigami92 Shinigami92 added m: image Something is referring to the image module p: 1-normal Nothing urgent labels Mar 23, 2023
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 23, 2023
ST-DDT
ST-DDT previously approved these changes Mar 23, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team March 23, 2023 14:05
@codecov
Copy link

codecov bot commented Mar 23, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (next@063ba6e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 583447f differs from pull request most recent head 77bcf2c. Consider uploading reports for the commit 77bcf2c to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1968   +/-   ##
=======================================
  Coverage        ?   99.62%           
=======================================
  Files           ?     2458           
  Lines           ?   239905           
  Branches        ?     1278           
=======================================
  Hits            ?   239017           
  Misses          ?      865           
  Partials        ?       23

matthewmayer
matthewmayer requested changes Mar 23, 2023
View reviewed changes
src/modules/image/index.ts Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Mar 23, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team March 23, 2023 18:23
matthewmayer
matthewmayer requested changes Mar 23, 2023
View reviewed changes
src/modules/image/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team March 23, 2023 18:59
@ST-DDT ST-DDT enabled auto-merge (squash) March 30, 2023 15:03
@ST-DDT ST-DDT merged commit b5bfca4 into next Mar 30, 2023
@ST-DDT ST-DDT deleted the 1964-use-seeded-picsum branch March 30, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working m: image Something is referring to the image module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

some urlPicsumPhotos are broken
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox