Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add af_ZA and zu_ZA states #1983

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Mar 28, 2023

@matthewmayer matthewmayer requested a review from a team as a code owner March 28, 2023 10:31
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1983 (c3b39ea) into next (063ba6e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c3b39ea differs from pull request most recent head 1d9a824. Consider uploading reports for the commit 1d9a824 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #1983    +/-   ##
========================================
  Coverage   99.62%   99.62%            
========================================
  Files        2460     2452     -8     
  Lines      240146   239774   -372     
  Branches     1275     1274     -1     
========================================
- Hits       239235   238882   -353     
+ Misses        888      870    -18     
+ Partials       23       22     -1     
Impacted Files Coverage Δ
src/locales/af_ZA/location/index.ts 100.00% <100.00%> (ø)
src/locales/af_ZA/location/state.ts 100.00% <100.00%> (ø)
src/locales/zu_ZA/location/index.ts 100.00% <100.00%> (ø)
src/locales/zu_ZA/location/state.ts 100.00% <100.00%> (ø)

... and 130 files with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Mar 28, 2023
@ST-DDT ST-DDT requested review from a team March 28, 2023 11:17
@ST-DDT
Copy link
Member

ST-DDT commented Mar 28, 2023

They have a strange naming pattern: Their Nord-West province is east of their Nord province. 🤣

grafik
(Or at least the names sound like that is the case)

@ST-DDT ST-DDT enabled auto-merge (squash) March 30, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants