Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add fi states #1986

Merged
merged 2 commits into from
Mar 29, 2023
Merged

feat(locale): add fi states #1986

merged 2 commits into from
Mar 29, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer requested a review from a team as a code owner March 29, 2023 06:13
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Mar 29, 2023
@matthewmayer matthewmayer self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (next@2c9e0b8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a57869c differs from pull request most recent head 7be676d. Consider uploading reports for the commit 7be676d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1986   +/-   ##
=======================================
  Coverage        ?   99.62%           
=======================================
  Files           ?     2452           
  Lines           ?   239783           
  Branches        ?     1272           
=======================================
  Hits            ?   238887           
  Misses          ?      874           
  Partials        ?       22

@ST-DDT ST-DDT requested a review from a team March 29, 2023 08:57
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 29, 2023
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 29, 2023 09:12
@Shinigami92 Shinigami92 merged commit 88e561a into next Mar 29, 2023
@ST-DDT ST-DDT deleted the chore/more-states-fi branch March 30, 2023 15:34
@matthewmayer matthewmayer mentioned this pull request May 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewmayer @ST-DDT @Shinigami92 @xDivisionByZerox