Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add en_US location.county data #1996

Merged
merged 3 commits into from
Apr 2, 2023

Conversation

matthewmayer
Copy link
Contributor

replaces #1988, part of #1944

Adds en_US data to use the most common US county names from https://en.wikipedia.org/wiki/List_of_the_most_common_U.S._county_names

As there are 3,006 counties in the US its not reasonable to add them all!

@matthewmayer matthewmayer requested a review from a team as a code owner March 30, 2023 10:23
@matthewmayer matthewmayer self-assigned this Mar 30, 2023
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Mar 30, 2023
@matthewmayer matthewmayer changed the title locale(location): add en_US counties feat(locale): add en_US location.county data Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #1996 (96924fa) into next (e4d4492) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1996      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2560     2561       +1     
  Lines      243198   243239      +41     
  Branches     1283     1279       -4     
==========================================
+ Hits       242302   242325      +23     
- Misses        871      889      +18     
  Partials       25       25              
Impacted Files Coverage Δ
src/locales/en_US/location/county.ts 100.00% <100.00%> (ø)
src/locales/en_US/location/index.ts 100.00% <100.00%> (ø)
src/modules/location/index.ts 98.93% <100.00%> (+0.21%) ⬆️

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from a team March 30, 2023 10:43
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 30, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) April 2, 2023 21:12
@ST-DDT ST-DDT merged commit 34b743a into faker-js:next Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants