Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): fix broken street address reference in fr_CH #2007

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 2, 2023

Neither fr

building_number,
city,
city_name,
country,
default_country,
direction,
postcode,
secondary_address,
state,
street,
street_address,
street_prefix,
street_suffix,

Nor fr_CH

building_number,
city,
city_name,
country,
country_code,
default_country,
direction,
postcode,
secondary_address,
state,
state_abbr,
street,
street_address,
street_prefix,
street_suffix,

have definitions.location.street_name files.
Thus the pattern needs to be adjusted.

Found in #2004 (comment)

@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels Apr 2, 2023
@ST-DDT ST-DDT requested review from a team April 2, 2023 10:42
@ST-DDT ST-DDT self-assigned this Apr 2, 2023
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #2007 (3d0e89b) into next (34b743a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 3d0e89b differs from pull request most recent head 54d42af. Consider uploading reports for the commit 54d42af to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2007      +/-   ##
==========================================
+ Coverage   99.61%   99.62%   +0.01%     
==========================================
  Files        2561     2561              
  Lines      243239   243239              
  Branches     1274     1280       +6     
==========================================
+ Hits       242301   242331      +30     
+ Misses        913      883      -30     
  Partials       25       25              
Impacted Files Coverage Δ
src/locales/fr_CH/location/street_address.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from a team April 2, 2023 12:42
@ST-DDT ST-DDT enabled auto-merge (squash) April 3, 2023 15:43
@ST-DDT ST-DDT merged commit cbbc076 into next Apr 3, 2023
15 checks passed
@ST-DDT ST-DDT deleted the fix/locale/fr_CH/location/street_address branch April 3, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants