Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in Faker jsdocs #2008

Merged
merged 2 commits into from
Apr 2, 2023
Merged

fix: typo in Faker jsdocs #2008

merged 2 commits into from
Apr 2, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 2, 2023 •
edited
Loading

Minor typo

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 2, 2023
@ST-DDT ST-DDT requested review from a team April 2, 2023 10:58
@ST-DDT ST-DDT self-assigned this Apr 2, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) April 2, 2023 10:59
@codecov
Copy link

codecov bot commented Apr 2, 2023 •
edited
Loading

Codecov Report

Merging #2008 (ce744a8) into next (9bf0a6d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2008   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2560     2560           
  Lines      243198   243198           
  Branches     1279     1280    +1     
=======================================
+ Hits       242289   242297    +8     
+ Misses        884      876    -8     
  Partials       25       25
Impacted Files Coverage Δ
src/faker.ts 91.77% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT merged commit 9d904a3 into next Apr 2, 2023
@xDivisionByZerox xDivisionByZerox deleted the docs/typo/Faker branch April 2, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox