Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(date): introduce anytime #2096

Merged
merged 3 commits into from
Apr 26, 2023
Merged

feat(date): introduce anytime #2096

merged 3 commits into from
Apr 26, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 25, 2023 •
edited

grafik

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent labels Apr 25, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Apr 25, 2023
@ST-DDT ST-DDT requested review from a team April 25, 2023 19:09
@ST-DDT ST-DDT self-assigned this Apr 25, 2023
@ST-DDT ST-DDT requested a review from a team April 25, 2023 19:09
Shinigami92
Shinigami92 previously approved these changes Apr 25, 2023
View reviewed changes
@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Apr 25, 2023
@Shinigami92 Shinigami92 linked an issue Apr 25, 2023 that may be closed by this pull request
date.anytime #2093
Closed
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited

Codecov Report

Merging #2096 (33ec223) into next (4d0458c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 33ec223 differs from pull request most recent head f2b18fc. Consider uploading reports for the commit f2b18fc to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2096      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2567     2567              
  Lines      243328   243363      +35     
  Branches     1251     1252       +1     
==========================================
+ Hits       242347   242378      +31     
- Misses        954      958       +4     
  Partials       27       27
Impacted Files Coverage Δ
src/modules/datatype/index.ts 100.00% <100.00%> (ø)
src/modules/date/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from Shinigami92 and a team April 25, 2023 19:30
@Shinigami92 Shinigami92 merged commit 3fc7bf1 into next Apr 26, 2023
15 checks passed
@Shinigami92 Shinigami92 deleted the feat/date/anytime branch April 26, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer left review comments

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

date.anytime
5 participants
@ST-DDT @matthewmayer @Shinigami92 @import-brain @xDivisionByZerox