-
-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(locale): el county should be city_name #2106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `el` city_pattern file isn’t very useful, as it refers to city_prefix and city_suffix which don’t exist in `el` - {{location.city_prefix}} {{person.firstName}} {{location.city_suffix}} e.g. Lake Χρήστοςton - {{location.city_prefix}} {{person.firstName}} e.g. West Βασίλης - {{person.firstName}}{{location.city_suffix}} e.g. Μαριαburgh - {{person.lastName}}{{location.city_suffix}} e.g. Κανακάρης-Ρούφοςboro In fact, the country.ts file actually includes city names, not 1st level administrative entities. So rename that to city_name and use `'{{location.city_name}}'` for cities.
matthewmayer
added
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
labels
Apr 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2106 +/- ##
==========================================
+ Coverage 99.59% 99.60% +0.01%
==========================================
Files 2605 2605
Lines 244949 244963 +14
Branches 1252 1256 +4
==========================================
+ Hits 243956 243995 +39
+ Misses 966 941 -25
Partials 27 27
|
ST-DDT
previously approved these changes
Apr 29, 2023
This needs to be updated as well. |
# Conflicts: # src/locales/el/location/index.ts
ST-DDT
approved these changes
May 1, 2023
Shinigami92
approved these changes
May 1, 2023
xDivisionByZerox
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
el
city_pattern file isn’t very useful, as it refers to city_prefix and city_suffix which don’t exist inel
In fact, the country.ts file actually includes city names, not 1st level administrative entities. So rename that to city_name and use
'{{location.city_name}}'
for cities.