Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): el county should be city_name #2106

Merged
merged 6 commits into from
May 2, 2023

Conversation

matthewmayer
Copy link
Contributor

The el city_pattern file isn’t very useful, as it refers to city_prefix and city_suffix which don’t exist in el

  • {{location.city_prefix}} {{person.firstName}} {{location.city_suffix}} e.g. Lake Χρήστοςton
  • {{location.city_prefix}} {{person.firstName}} e.g. West Βασίλης
  • {{person.firstName}}{{location.city_suffix}} e.g. Μαριαburgh
  • {{person.lastName}}{{location.city_suffix}} e.g. Κανακάρης-Ρούφοςboro

In fact, the country.ts file actually includes city names, not 1st level administrative entities. So rename that to city_name and use '{{location.city_name}}' for cities.

The `el` city_pattern file isn’t very useful, as it refers to city_prefix and city_suffix which don’t exist in `el`

- {{location.city_prefix}} {{person.firstName}} {{location.city_suffix}} e.g. Lake Χρήστοςton
- {{location.city_prefix}} {{person.firstName}} e.g. West Βασίλης
- {{person.firstName}}{{location.city_suffix}} e.g. Μαριαburgh
- {{person.lastName}}{{location.city_suffix}} e.g. Κανακάρης-Ρούφοςboro

In fact, the country.ts file actually includes city names, not 1st level administrative entities. So rename that to city_name and use `'{{location.city_name}}'` for cities.
@matthewmayer matthewmayer requested a review from a team as a code owner April 28, 2023 14:56
@matthewmayer matthewmayer self-assigned this Apr 28, 2023
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #2106 (6b61743) into next (e094a5a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 6b61743 differs from pull request most recent head 5c25e4e. Consider uploading reports for the commit 5c25e4e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2106      +/-   ##
==========================================
+ Coverage   99.59%   99.60%   +0.01%     
==========================================
  Files        2605     2605              
  Lines      244949   244963      +14     
  Branches     1252     1256       +4     
==========================================
+ Hits       243956   243995      +39     
+ Misses        966      941      -25     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/el/location/city_name.ts 100.00% <ø> (ø)
src/locales/el/location/city_pattern.ts 100.00% <100.00%> (ø)
src/locales/el/location/index.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Apr 29, 2023
@ST-DDT ST-DDT requested review from a team April 29, 2023 17:17
@ST-DDT
Copy link
Member

ST-DDT commented May 1, 2023

This needs to be updated as well.

@ST-DDT ST-DDT added the needs rebase There is a merge conflict label May 1, 2023
@matthewmayer matthewmayer removed the needs rebase There is a merge conflict label May 1, 2023
@ST-DDT ST-DDT requested a review from a team May 1, 2023 10:19
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 1, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) May 2, 2023 08:57
@ST-DDT ST-DDT merged commit 1cadfb9 into faker-js:next May 2, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants