fix(locale): es cities should be in city_name not city_prefix, remove extraneous city_suffix #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extraneous city_suffix
matthewmayer
added
p: 1-normal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2109 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 2567 2566 -1
Lines 243371 243349 -22
Branches 1252 1252
==========================================
- Hits 242396 242363 -33
- Misses 948 959 +11
Partials 27 27
|
matthewmayer
changed the title
ST-DDT
approved these changes
Apr 29, 2023
Shinigami92
approved these changes
Apr 29, 2023
xDivisionByZerox
approved these changes
Apr 29, 2023
matthewmayer
added a commit
to matthewmayer/faker
that referenced
this pull request
Apr 30, 2023
…ocker similar to faker-js#2109 for en_* locales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both es and es_MX have a real list of cities incorrectly in city_prefix
instead of city_name.
Also removed unused English suffixes in es_MX locale