feat(locale): add states for Croatia (hr) #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmayer
added
c: feature
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2142 +/- ##
=======================================
Coverage 99.60% 99.61%
=======================================
Files 2784 2786 +2
Lines 252492 252522 +30
Branches 1082 1085 +3
=======================================
+ Hits 251496 251544 +48
+ Misses 969 951 -18
Partials 27 27
|
ST-DDT
reviewed
May 9, 2023
There was a problem hiding this comment.
It might be best to just call them counties here.
As for states we could use these https://en.wikipedia.org/wiki/Regions_of_Croatia or omit them entirely.
|
Team Decision We will jump to a definition loophole and will put it in both state (as first level administrative unit) and in county (as county names). We will create a separate issue to clarify that states ~= |
ST-DDT
requested changes
Aug 31, 2023
ST-DDT
approved these changes
Sep 1, 2023
xDivisionByZerox
approved these changes
Sep 9, 2023
import-brain
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1977
There are 21 counties
https://en.wikipedia.org/wiki/Counties_of_Croatia
https://hr.wikipedia.org/wiki/Hrvatske_%C5%BEupanije