Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(location): fi addresses #2146

Merged
merged 4 commits into from
Jun 17, 2023
Merged

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented May 10, 2023

Adds better address data for fi locale: cities, postcodes, streets, building numbers

fakerFI.helpers.multiple(()=>`${fakerFI.location.streetAddress(fakerFI.datatype.boolean())}, ${fakerFI.location.zipCode()} ${fakerFI.location.city()}, ${fakerFI.location.state()}`, {count:10})
[
  'Savolainenkaari 107, 91082 Joensuu, Keski-Pohjanmaa',
  'Laaksonenkuja 7 C, 60772 Valkeakoski, Uusimaa',
  'Maijaraitti 2, 98331 Turku, Varsinais-Suomi',
  'Manninenpenger 40 C 42, 88993 Espoo, Etelä-Pohjanmaa',
  'Manninenkuja 276, 00517 Oulu, Kainuu',
  'Ainoraitti 6 C, 18199 Turku, Keski-Suomi',
  'Kinnunentie 4 A, 71303 Kokkola, Ahvenanmaa',
  'Lehtonenkuja 6 A 3, 44938 Pori, Pohjois-Savo',
  'Laaksolinja 9 B, 35564 Oulu, Uusimaa',
  'Markopenger 82 C 91, 08384 Rovaniemi, Etelä-Savo'
]

References:

  • City names: 1, 2
  • Postcodes 3
  • Street suffixes: 4
  • Building numbers: 5, 6

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2146 (0e05520) into next (fd8cfe5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0e05520 differs from pull request most recent head dec7a7e. Consider uploading reports for the commit dec7a7e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2146    +/-   ##
========================================
  Coverage   99.60%   99.60%            
========================================
  Files        2623     2615     -8     
  Lines      245504   245092   -412     
  Branches     1156     1155     -1     
========================================
- Hits       244525   244117   -408     
+ Misses        952      948     -4     
  Partials       27       27            
Impacted Files Coverage Δ
src/locales/fi/location/building_number.ts 100.00% <100.00%> (ø)
src/locales/fi/location/city_name.ts 100.00% <100.00%> (ø)
src/locales/fi/location/city_pattern.ts 100.00% <100.00%> (ø)
src/locales/fi/location/index.ts 100.00% <100.00%> (ø)
src/locales/fi/location/postcode.ts 100.00% <100.00%> (ø)
src/locales/fi/location/secondary_address.ts 100.00% <100.00%> (ø)
src/locales/fi/location/street_address.ts 100.00% <100.00%> (ø)
src/locales/fi/location/street_pattern.ts 100.00% <100.00%> (ø)
src/locales/fi/location/street_suffix.ts 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

@matthewmayer matthewmayer marked this pull request as ready for review May 11, 2023 01:42
@matthewmayer matthewmayer requested a review from a team as a code owner May 11, 2023 01:43
@matthewmayer matthewmayer self-assigned this May 11, 2023
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels May 11, 2023
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Jun 1, 2023

Technically the title should be of the topic locale with the scope fi. feature is only used to actual new methods in modules, no?

NVM, I'm stupid and forgot how our commit conventions work.

@ST-DDT ST-DDT enabled auto-merge (squash) June 17, 2023 10:58
@ST-DDT ST-DDT merged commit 1da6785 into faker-js:next Jun 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants