feat(color): migrate hu human colors #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like the hu definition file was missed in faker-js#801 when migrating from faker.commerce.color to faker.color.human
matthewmayer
added
p: 1-normal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2157 +/- ##
==========================================
- Coverage 99.60% 99.59% -0.01%
==========================================
Files 2622 2623 +1
Lines 245479 245491 +12
Branches 1155 1150 -5
==========================================
- Hits 244509 244504 -5
- Misses 943 960 +17
Partials 27 27
|
xDivisionByZerox
approved these changes
Jun 5, 2023
ST-DDT
approved these changes
Jun 5, 2023
import-brain
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like the hu definition file was missed in #801 when migrating from faker.commerce.color to faker.color.human