Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add database for German (de) #2226

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

inkedtree
Copy link
Contributor

I extended the german locale (de) by adding data definitions for database.

@inkedtree inkedtree requested a review from a team as a code owner June 26, 2023 19:55
@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature c: locale Permutes locale definitions m: database Something is referring to the database module labels Jun 26, 2023
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Those values look reasonable enough for me 👍

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2226 (a349dee) into next (2f0ea79) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2226      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2637     2639       +2     
  Lines      245674   245709      +35     
  Branches     1154     1156       +2     
==========================================
+ Hits       244699   244732      +33     
- Misses        948      950       +2     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/de/database/column.ts 100.00% <100.00%> (ø)
src/locales/de/database/index.ts 100.00% <100.00%> (ø)
src/locales/de/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@import-brain import-brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through Google Translate, LGTM

@ST-DDT ST-DDT merged commit ee12c32 into faker-js:next Jun 27, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions m: database Something is referring to the database module
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants